Rebase netapp - #86
Merged
Merged
Conversation
…for upload operations
…revent duplicate volume and primary storage increment on import
apache#12833) Fixes an issue in NsxResource.executeRequest where Network.Service comparison failed when DeleteNsxNatRuleCommand was executed in a different process. Due to serialization/deserialization, the deserialized Network.Service instance was not equal to the static instances Network.Service.StaticNat and Network.Service.PortForwarding, causing the comparison to always return false. Co-authored-by: Andrey Volchkov <avolchkov@playtika.com> (cherry picked from commit 30dd234)
…ations (apache#12883) * Move logs for values of the migration settings out of the loop * Apply suggestions from code review Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> --------- Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
…pache#12884) * Fix NPE on external/unmanaged instance import using custom offerings
…12885) * Fix revertVM with custom svc offering
* merge conflict fixes * fix pre-commit issue Co-authored-by: Daan Hoogland <dahn@apache.org> Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
* bugfix: Fix volume attach in iSCSI for ONTAP plugin (#54) * Bugfix: Zone scoped Instance creation fix
… -> 4.23.0 path (apache#13617)
apache#578) (apache#13551) * ConfigureStorageAccessCmd: Allow storage access configuration on empty clusters/pods/zones * update as per comments * update as per review comments * update as per comments --------- (cherry picked from commit 32736b9e262522912cf8755acabfb7400006252f) Co-authored-by: Sachin R <32716246+sachindoddaguni@users.noreply.github.com> Co-authored-by: Sachin R Doddaguni <s_rudrappadoddagu@apple.com> Co-authored-by: mprokopchuk <mprokopchuk@gmail.com>
…apache#13615) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…upsResponse for non-kboss providers (apache#13661)
* 4.22: UI: fix blank page when list Other OSes in VNF appliance deployment (apache#13620) ConfigureStorageAccessCmd: Allow storage access configuration on empt… (apache#578) (apache#13551)
Resolve conflicts in KvmFileBasedStorageVmSnapshotStrategy (align disk-only snapshot API with upstream) and LibvirtCreateDiskOnlyVMSnapshotCommandWrapper. Co-authored-by: Cursor <cursoragent@cursor.com>
StorageStrategyTest calls mock() and never() without importing them, so cloud-plugin-storage-volume-ontap fails testCompile. Introduced by 065269a (#66), which added the calls but not the imports. The failure only surfaces in CI because the PR build compiles the merge of this branch into main, where main's copy of the file supersedes ours. Co-authored-by: Cursor <cursoragent@cursor.com>
rajiv-jain-netapp
requested review from
piyush5netapp,
sandeeplocharla and
suryag1201
as code owners
August 10, 2026 07:21
The Codecov step in sonar-check.yml is the only unguarded one in the repo; every other usage fences off forks at the step or job level. Without CODECOV_TOKEN the action attempts a tokenless upload, which Codecov rejects with HTTP 400, and fail_ci_if_error turns that into a job failure. Guarding it matches the pattern already used in ui.yml and lets the Compute Coverage Grade steps run, restoring the coverage comment. Co-authored-by: Cursor <cursoragent@cursor.com>
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.58% |
| Branch coverage | 18.76% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sandeeplocharla
approved these changes
Aug 10, 2026
suryag1201
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?